Skip to content

Commit fc84652

Browse files
author
epriestley
committed
Add "View All" header buttons to user and project feed boxes
Summary: Fixes T12762. Currently, there's no way to get from these boxes into generaly history in Feed, and it isn't clear that the operation is possible. For now, add some simple links. See T12762 for future work. Test Plan: - Viewed user profles, saw "View All". - Viewed project profiles, saw "View All". {F4978858} Reviewers: chad Reviewed By: chad Maniphest Tasks: T12762 Differential Revision: https://secure.phabricator.com/D18030
1 parent 46a33c0 commit fc84652

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,21 @@ public function handleRequest(AphrontRequest $request) {
2828
$name = $user->getUsername();
2929

3030
$feed = $this->buildPeopleFeed($user, $viewer);
31+
32+
$view_all = id(new PHUIButtonView())
33+
->setTag('a')
34+
->setIcon(
35+
id(new PHUIIconView())
36+
->setIcon('fa-list-ul'))
37+
->setText(pht('View All'))
38+
->setHref('/feed/?userPHIDs='.$user->getPHID());
39+
40+
$feed_header = id(new PHUIHeaderView())
41+
->setHeader(pht('Recent Activity'))
42+
->addActionLink($view_all);
43+
3144
$feed = id(new PHUIObjectBoxView())
32-
->setHeaderText(pht('Recent Activity'))
45+
->setHeader($feed_header)
3346
->addClass('project-view-feed')
3447
->appendChild($feed);
3548

src/applications/project/controller/PhabricatorProjectProfileController.php

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,21 @@ public function handleRequest(AphrontRequest $request) {
8080
->setLimit(50)
8181
->execute();
8282

83+
$view_all = id(new PHUIButtonView())
84+
->setTag('a')
85+
->setIcon(
86+
id(new PHUIIconView())
87+
->setIcon('fa-list-ul'))
88+
->setText(pht('View All'))
89+
->setHref('/feed/?projectPHIDs='.$project->getPHID());
90+
91+
$feed_header = id(new PHUIHeaderView())
92+
->setHeader(pht('Recent Activity'))
93+
->addActionLink($view_all);
94+
8395
$feed = $this->renderStories($stories);
8496
$feed = id(new PHUIObjectBoxView())
85-
->setHeaderText(pht('Recent Activity'))
97+
->setHeader($feed_header)
8698
->addClass('project-view-feed')
8799
->appendChild($feed);
88100

0 commit comments

Comments
 (0)