Put subprojects and milestones back into the Project UI

Summary: Ref T10010. Restores subprojects and milestones to the UI with a more modern style and more warnings.

Test Plan:
{F1085207}

{F1085208}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010

Differential Revision: https://secure.phabricator.com/D15152

Author: epriestley

src/__phutil_library_map__.php

@@ -2913,7 +2913,6 @@
     'PhabricatorProjectMembersProfilePanel' => 'applications/project/profilepanel/PhabricatorProjectMembersProfilePanel.php',
     'PhabricatorProjectMembersRemoveController' => 'applications/project/controller/PhabricatorProjectMembersRemoveController.php',
     'PhabricatorProjectMembersViewController' => 'applications/project/controller/PhabricatorProjectMembersViewController.php',
-    'PhabricatorProjectMilestonesController' => 'applications/project/controller/PhabricatorProjectMilestonesController.php',
     'PhabricatorProjectMoveController' => 'applications/project/controller/PhabricatorProjectMoveController.php',
     'PhabricatorProjectNameContextFreeGrammar' => 'applications/project/lipsum/PhabricatorProjectNameContextFreeGrammar.php',
     'PhabricatorProjectNoProjectsDatasource' => 'applications/project/typeahead/PhabricatorProjectNoProjectsDatasource.php',
@@ -2937,7 +2936,9 @@
     'PhabricatorProjectSlug' => 'applications/project/storage/PhabricatorProjectSlug.php',
     'PhabricatorProjectStandardCustomField' => 'applications/project/customfield/PhabricatorProjectStandardCustomField.php',
     'PhabricatorProjectStatus' => 'applications/project/constants/PhabricatorProjectStatus.php',
+    'PhabricatorProjectSubprojectWarningController' => 'applications/project/controller/PhabricatorProjectSubprojectWarningController.php',
     'PhabricatorProjectSubprojectsController' => 'applications/project/controller/PhabricatorProjectSubprojectsController.php',
+    'PhabricatorProjectSubprojectsProfilePanel' => 'applications/project/profilepanel/PhabricatorProjectSubprojectsProfilePanel.php',
     'PhabricatorProjectTestDataGenerator' => 'applications/project/lipsum/PhabricatorProjectTestDataGenerator.php',
     'PhabricatorProjectTransaction' => 'applications/project/storage/PhabricatorProjectTransaction.php',
     'PhabricatorProjectTransactionEditor' => 'applications/project/editor/PhabricatorProjectTransactionEditor.php',
@@ -7330,7 +7331,6 @@
     'PhabricatorProjectMembersProfilePanel' => 'PhabricatorProfilePanel',
     'PhabricatorProjectMembersRemoveController' => 'PhabricatorProjectController',
     'PhabricatorProjectMembersViewController' => 'PhabricatorProjectController',
-    'PhabricatorProjectMilestonesController' => 'PhabricatorProjectController',
     'PhabricatorProjectMoveController' => 'PhabricatorProjectController',
     'PhabricatorProjectNameContextFreeGrammar' => 'PhutilContextFreeGrammar',
     'PhabricatorProjectNoProjectsDatasource' => 'PhabricatorTypeaheadDatasource',
@@ -7357,7 +7357,9 @@
       'PhabricatorStandardCustomFieldInterface',
     ),
     'PhabricatorProjectStatus' => 'Phobject',
+    'PhabricatorProjectSubprojectWarningController' => 'PhabricatorProjectController',
     'PhabricatorProjectSubprojectsController' => 'PhabricatorProjectController',
+    'PhabricatorProjectSubprojectsProfilePanel' => 'PhabricatorProfilePanel',
     'PhabricatorProjectTestDataGenerator' => 'PhabricatorTestDataGenerator',
     'PhabricatorProjectTransaction' => 'PhabricatorApplicationTransaction',
     'PhabricatorProjectTransactionEditor' => 'PhabricatorApplicationTransactionEditor',

src/applications/project/application/PhabricatorProjectApplication.php

@@ -91,6 +91,8 @@ public function getRoutes() {
           => 'PhabricatorProjectWatchController',
         'silence/(?P<id>[1-9]\d*)/'
           => 'PhabricatorProjectSilenceController',
+        'warning/(?P<id>[1-9]\d*)/'
+          => 'PhabricatorProjectSubprojectWarningController',
       ),
       '/tag/' => array(
         '(?P<slug>[^/]+)/' => 'PhabricatorProjectViewController',

src/applications/project/controller/PhabricatorProjectEditController.php

@@ -42,6 +42,7 @@ public function handleRequest(AphrontRequest $request) {
       if ($parent_id) {
         $query = id(new PhabricatorProjectQuery())
           ->setViewer($viewer)
+          ->needImages(true)
           ->requireCapabilities(
             array(
               PhabricatorPolicyCapability::CAN_VIEW,
@@ -58,7 +59,7 @@ public function handleRequest(AphrontRequest $request) {
 
         if ($is_milestone) {
           if (!$parent->supportsMilestones()) {
-            $cancel_uri = "/project/milestones/{$parent_id}/";
+            $cancel_uri = "/project/subprojects/{$parent_id}/";
             return $this->newDialog()
               ->setTitle(pht('No Milestones'))
               ->appendParagraph(
@@ -91,20 +92,13 @@ protected function buildApplicationCrumbs() {
     $engine = $this->getEngine();
     if ($engine) {
       $parent = $engine->getParentProject();
-      if ($parent) {
-        $id = $parent->getID();
+      $milestone = $engine->getMilestoneProject();
+      if ($parent || $milestone) {
+        $id = nonempty($parent, $milestone)->getID();
         $crumbs->addTextCrumb(
           pht('Subprojects'),
           $this->getApplicationURI("subprojects/{$id}/"));
       }
-
-      $milestone = $engine->getMilestoneProject();
-      if ($milestone) {
-        $id = $milestone->getID();
-        $crumbs->addTextCrumb(
-          pht('Milestones'),
-          $this->getApplicationURI("milestones/{$id}/"));
-      }
     }
 
     return $crumbs;

src/applications/project/controller/PhabricatorProjectMilestonesController.php

@@ -45,6 +45,9 @@ public function handleRequest(AphrontRequest $request) {
     $watch_action = $this->renderWatchAction($project);
     $header->addActionLink($watch_action);
 
+    $milestone_list = $this->buildMilestoneList($project);
+    $subproject_list = $this->buildSubprojectList($project);
+
     $member_list = id(new PhabricatorProjectMemberListView())
       ->setUser($viewer)
       ->setProject($project)
@@ -82,6 +85,8 @@ public function handleRequest(AphrontRequest $request) {
         ))
       ->setSideColumn(
         array(
+          $milestone_list,
+          $subproject_list,
           $member_list,
           $watcher_list,
         ));
@@ -176,5 +181,90 @@ private function renderWatchAction(PhabricatorProject $project) {
       ->setHref($watch_href);
   }
 
+  private function buildMilestoneList(PhabricatorProject $project) {
+    if (!$project->getHasMilestones()) {
+      return null;
+    }
+
+    $viewer = $this->getViewer();
+    $id = $project->getID();
+
+    $milestones = id(new PhabricatorProjectQuery())
+      ->setViewer($viewer)
+      ->withParentProjectPHIDs(array($project->getPHID()))
+      ->needImages(true)
+      ->withIsMilestone(true)
+      ->setOrder('newest')
+      ->execute();
+    if (!$milestones) {
+      return null;
+    }
+
+    $milestone_list = id(new PhabricatorProjectListView())
+      ->setUser($viewer)
+      ->setProjects($milestones)
+      ->renderList();
+
+    $view_all = id(new PHUIButtonView())
+      ->setTag('a')
+      ->setIcon(
+        id(new PHUIIconView())
+          ->setIcon('fa-list-ul'))
+      ->setText(pht('View All'))
+      ->setHref("/project/subprojects/{$id}/");
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader(pht('Milestones'))
+      ->addActionLink($view_all);
+
+    return id(new PHUIObjectBoxView())
+      ->setHeader($header)
+      ->setBackground(PHUIBoxView::GREY)
+      ->setObjectList($milestone_list);
+  }
+
+  private function buildSubprojectList(PhabricatorProject $project) {
+    if (!$project->getHasSubprojects()) {
+      return null;
+    }
+
+    $viewer = $this->getViewer();
+    $id = $project->getID();
+
+    $limit = 25;
+
+    $subprojects = id(new PhabricatorProjectQuery())
+      ->setViewer($viewer)
+      ->withParentProjectPHIDs(array($project->getPHID()))
+      ->needImages(true)
+      ->withIsMilestone(false)
+      ->setLimit($limit)
+      ->execute();
+    if (!$subprojects) {
+      return null;
+    }
+
+    $subproject_list = id(new PhabricatorProjectListView())
+      ->setUser($viewer)
+      ->setProjects($subprojects)
+      ->renderList();
+
+    $view_all = id(new PHUIButtonView())
+      ->setTag('a')
+      ->setIcon(
+        id(new PHUIIconView())
+          ->setIcon('fa-list-ul'))
+      ->setText(pht('View All'))
+      ->setHref("/project/subprojects/{$id}/");
+
+    $header = id(new PHUIHeaderView())
+      ->setHeader(pht('Subprojects'))
+      ->addActionLink($view_all);
+
+    return id(new PHUIObjectBoxView())
+      ->setHeader($header)
+      ->setBackground(PHUIBoxView::GREY)
+      ->setObjectList($subproject_list);
+  }
 
 }

src/applications/project/controller/PhabricatorProjectProfileController.php

@@ -0,0 +1,51 @@
+<?php
+
+final class PhabricatorProjectSubprojectWarningController
+  extends PhabricatorProjectController {
+
+  public function handleRequest(AphrontRequest $request) {
+    $viewer = $request->getViewer();
+
+    $response = $this->loadProject();
+    if ($response) {
+      return $response;
+    }
+
+    $project = $this->getProject();
+
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $viewer,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
+
+    if (!$can_edit) {
+      return new Aphront404Response();
+    }
+
+    $id = $project->getID();
+    $cancel_uri = "/project/subprojects/{$id}/";
+    $done_uri = "/project/edit/?parent={$id}";
+
+    if ($request->isFormPost()) {
+      return id(new AphrontRedirectResponse())
+        ->setURI($done_uri);
+    }
+
+    $doc_href = PhabricatorEnv::getDoclink('Projects User Guide');
+
+    $conversion_help = pht(
+      "Creating a project's first subproject **moves all ".
+      "members** and **destroys all workboard columns**.".
+      "\n\n".
+      "See [[ %s | Projects User Guide ]] in the documentation for details. ".
+      "This process can not be undone.",
+      $doc_href);
+
+    return $this->newDialog()
+      ->setTitle(pht('Convert to Parent Project'))
+      ->appendChild(new PHUIRemarkupView($viewer, $conversion_help))
+      ->addCancelButton($cancel_uri)
+      ->addSubmitButton(pht('Convert Project'));
+  }
+
+}