feat(core): add IDL registration and retrieval RPC methods#255
feat(core): add IDL registration and retrieval RPC methods#255
Conversation
…. And for get_transaction_profile. - Fixed unexpected behavior of querying on futures slots with a precise filter.
|
|
||
| // Test 7: Verify context slot is correct | ||
| println!("Verifying response context"); | ||
| let uuid_response_with_context = rpc_server |
There was a problem hiding this comment.
We're not actually verifying any slot here, is that intentional?
…lot handling logic. Added new IDL version for testing and removed redundant debug prints.
…re and improving error handling in SvmTricksRpc implementation
| /// "id": 1 | ||
| /// } | ||
| /// ``` | ||
| #[rpc(meta, name = "surfnet_getIdl")] |
There was a problem hiding this comment.
surfnet_getIdl or surfnet_getActiveIdl?
There was a problem hiding this comment.
It's get Idl because you can query for a specific one using the slot
There was a problem hiding this comment.
yeah we're not providing an Idl identifier, we're querying using a property. maybe getIdlBySlot? Idk, but it feels like something is missing here.
There was a problem hiding this comment.
Ok, lets discuss it in tmrw's daily
| @@ -0,0 +1,394 @@ | |||
| { | |||
There was a problem hiding this comment.
these kind of files are generally referred to as fixtures, vs assets
lgalabru
left a comment
lgalabru
left a comment
There was a problem hiding this comment.
Looking great, thank you for the extensive testing 🙏
|
was a good one to test🫡 |
3 participants
No description provided.