CI: Don't specify bash for the semver step#135
Merged
joncinque merged 1 commit intosolana-program:mainfrom Aug 11, 2025
Merged
Conversation
#### Problem The publish job fails for proc-macro crates because they don't specify a crate-type. This means that the first call to `toml get ...` fails, which causes the whole job to fail. #### Summary of changes Cargo issues a warning if you specify `crate-type = ["proc-macro"]`, so rather than creating a new warning, simply allow for errors when searching for the string.
grod220
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish job fails for proc-macro crates because they don't specify a crate-type. This means that the first call to
toml get ...fails, which causes the whole job to fail.Summary of changes
Cargo issues a warning if you specify
crate-type = ["proc-macro"], so rather than creating a new warning, simply allow for errors when searching for the string.