Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds base interfaces for the program: instructions, state, message schema, and PDA types.
Overall objective
Write a program that can serve as a functional replacement for the durable nonce usecase:
The difference is that durable nonces do this via special runtime functionality (that folks are interested in removing), while this program does it through a signed program message.
Instead of signing a full transaction offline, authority members sign a structured
SignedMessagethat commits to the exact action being approved. It doesn't require any special features and can work today. Even further, it can enable additional features like signature expiry.Inspiration
Trent's durable nonce replacement proposal: solana-foundation/solana-improvement-documents#456
High-level design
NonceState: which stores the current nonce plus theAuthorityPolicyNonceStatePda: the PDA that stores stateNonceAuthorityPda: the PDA the program signs as during CPIInstructionData/SignedMessage: the offline-signed authorization formatSignedAction: Supported actions that can be executed by the programThe intended flow is:
SignedMessageSubmitDivergences from original proposal
This follows the spirit of Trent's original proposal, but there are a few divergences:
AuthorityPolicywith threshold plus ordered members, rather than a single authority keyWhat's next