tests: fix ProgramTest program selection#595
Merged
2501babe merged 1 commit intosolana-program:mainfrom Apr 3, 2026
Merged
Conversation
* replace `add_upgradeable_program_to_genesis()` with `add_program()` * remove small deposit/withdraw cases, minimum delegation disallows these * account for upstream merge improvement to merge excess lamports
joncinque
approved these changes
Apr 3, 2026
| // remove branch after v5 is stable | ||
| alice_stake_before_deposit + rent_exempt_reserve | ||
| } else { | ||
| alice_stake_before_deposit + rent_exempt_reserve + alice_extra_lamports |
Contributor
There was a problem hiding this comment.
It's very nice that your test catches this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_upgradeable_program_to_genesis()is broken (again?) and we were testing against whatever bpf stake we got fromProgramTest😞 i realized while working on #581 i was getting test states that, given minimum delegation, ought to be impossible