Skip to content

interface: use new solana-stake-history crate#448

Merged
grod220 merged 1 commit into
mainfrom
new-stk-history
Jun 29, 2026
Merged

interface: use new solana-stake-history crate#448
grod220 merged 1 commit into
mainfrom
new-stk-history

Conversation

@grod220

@grod220 grod220 commented Jun 26, 2026

Copy link
Copy Markdown
Member

Re-exports migrated types from anza-xyz/solana-sdk#766.

Proposed semver bump as patch given there are no API changes. Though minor is also defensible given dep graph changes if folks feel otherwise. Publish will follow this PR.

After running

cargo semver-checks --manifest-path interface/Cargo.toml

There are errs of missing entities:

solana_stake_interface::sysvar::stake_history::id
solana_stake_interface::sysvar::stake_history::check_id
solana_stake_interface::stake_history::SIZE
solana_stake_interface::stake_history::MAX_ENTRIES
solana_stake_interface::sysvar::stake_history::ID
solana_stake_interface::stake_history::StakeHistoryEntry
solana_stake_interface::state::StakeActivationStatus
solana_stake_interface::sysvar::stake_history::StakeHistorySysvar
solana_stake_interface::stake_history::StakeHistory
solana_stake_interface::stake_history::StakeHistoryGetEntry

But all of these are covered in the new re-exports

pub use solana_stake_history::sysvar::{check_id, id, StakeHistorySysvar, ID};

pub use solana_stake_history::{
    Epoch, StakeHistory, StakeHistoryEntry, StakeHistoryGetEntry, MAX_ENTRIES, SIZE,
};

pub type StakeActivationStatus = StakeHistoryEntry;

Comment thread idl.json
"pdas": [],
"publicKey": "Stake11111111111111111111111111111111111111",
"version": "4.2.0"
"version": "4.3.0"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stale on main, currently fails ci/cd

@grod220 grod220 marked this pull request as ready for review June 26, 2026 17:15
@grod220 grod220 requested review from buffalojoec and joncinque June 26, 2026 17:15

@joncinque joncinque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment thread interface/Cargo.toml
solana-pubkey = { version = "4.2.0", default-features = false }
solana-stake-history = "1.0.0"
solana-system-interface = "3.0.0"
solana-sysvar = { version = "4.0.0", optional = true }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is huge

@buffalojoec buffalojoec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EZ

@grod220 grod220 merged commit 99fcd2a into main Jun 29, 2026
25 checks passed
@grod220 grod220 deleted the new-stk-history branch June 29, 2026 05:44
@grod220 grod220 mentioned this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants