fix(audit): block recurring rollover into post-expiry periods (MULT-7)#33
Merged
dev-jodee merged 8 commits intoApr 28, 2026
Conversation
Skip rollover when candidate_start >= expiry_ts. Pulls within drift window remain valid in the final authorized period; no fresh allowance is granted in terminal periods. Affects validate_recurring_transfer (used by recurring delegations and subscription transfers).
Compute Unit Report
Generated: 2026-04-28 |
3 tasks
Extract is_effectively_expired helper. Sponsor revocation now waits the same TIME_DRIFT_ALLOWED_SECS past expiry that transfers tolerate, so sponsor cannot close a delegation while the delegatee can still pull.
Extend SubscribeData with expected_mint/amount/period_hours/created_at. Program rejects with PlanTermsMismatch if the live plan disagrees with what the subscriber signed. Stale-signed subscribe transactions can no longer enroll into a recreated plan with different terms. SDK and webapp callers fetch plan data and pass the snapshot.
Plan::check_destination and Plan::can_pull now filter out zero-padded slots before membership tests. A plan with fewer than four configured destinations no longer authorizes a zero-owned receiver, and a plan with fewer than four pullers no longer authorizes a zero-pubkey caller.
…-10) Webapp exit flows now pass the on-chain payer as receiver when it differs from the connected signer, so sponsor-funded delegations and SubscriptionAuthority accounts can actually be closed. Also migrates revokeSubscription and cancelAndRevokeSubscription from buildRevokeDelegation to buildRevokeSubscription with planPda + receiver, fixing subscription revoke for both sponsor and non-sponsor cases.
…(MULT-9) Stale-delegation cleanup no longer appends a close on the current SubscriptionAuthority. Revoking stale delegations is now scoped to the supplied delegation accounts; the SA stays open and current grants remain valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit finding: MULT-7
validate_recurring_transferallowed rollover into a post-expiry period whencurrent_tswas within the drift window, granting a fresh fullamount_per_periodallowance in a terminal period that should not exist. With short periods, the drift window enabled repeated post-expiry pulls.Fix
After computing the candidate next period start, only roll over if it stays strictly before
expiry_ts. Pulls inside the drift window remain valid against whatever allowance is left in the final authorized period; no fresh allowance is granted past expiry.Affects
validate_recurring_transferis the shared helper called by both:Both paths inherit the fix.
Test plan
cargo build -p subscriptionscargo test -p subscriptions --lib(211/211 pass; one new regression test)test_recurring_rollover_blocked_at_expiry_boundaryreproduces the scanner PoC and asserts the second post-expiry pull now fails withAmountExceedsPeriodLimittest_recurring_transfer_within_drift_windowandtest_recurring_transfer_past_drift_windowstill passStack
Stacked on top of #32 (MULT-16).