unify rust and js scripts #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
joec-unify-scripts
branch
from
f8c6aeb to
4464b3e
Compare
Member
|
Oh this is pretty clean 👀 |
buffalojoec
force-pushed
the
joec-unify-scripts
branch
2 times, most recently
from
a89af08 to
1550ddd
Compare
buffalojoec
force-pushed
the
joec-unify-scripts
branch
from
1550ddd to
11947d3
Compare
buffalojoec
requested review from
febo and
lorisleiva
and removed request for
lorisleiva
febo
reviewed
Dec 19, 2024
febo
reviewed
Dec 19, 2024
febo
approved these changes
Dec 19, 2024
Contributor
febo
left a comment
febo
left a comment
There was a problem hiding this comment.
Looks great! Just left a couple of questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea for unified Rust & JS scripts.