Skip to content

Merge partition arguments helper #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

Merge partition arguments helper #33

merged 1 commit into from
Dec 19, 2024

Conversation

@febo
Copy link
Contributor

@febo febo commented Dec 19, 2024

Problem

#32 introduced the partitionArgumentsWithDefaultArgs helper, which takes an optional defaultArgs parameter. Since the parameter is optional, it behaves the same way as the partitionArguments when it is not provided.

Improvement

Merge both partitionArguments and partitionArgumentsWithDefaultArgs helpers, since they behaviour is similar.

@febo febo requested a review from lorisleiva December 19, 2024 13:46
lorisleiva
lorisleiva approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🫶

@febo febo merged commit 6185b40 into main Dec 19, 2024
8 checks passed
@febo febo deleted the febo/partition-helper branch December 19, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@febo @lorisleiva