Add templateId to GetKakaoAlimtalkTemplatesFinalizeRequest#87
Add templateId to GetKakaoAlimtalkTemplatesFinalizeRequest#87dinnertime-who wants to merge 1 commit intosolapi:masterfrom
Conversation
Summary of ChangesHello @dinnertime-who, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| this.templateId = parameter.templateId; | ||
| this.isHidden = parameter.isHidden; |
There was a problem hiding this comment.
For better code consistency and maintainability, it's good practice to order property assignments in the constructor to match the order of their declaration in the class. The isHidden property is declared before templateId.
| this.templateId = parameter.templateId; | |
| this.isHidden = parameter.isHidden; | |
| this.isHidden = parameter.isHidden; | |
| this.templateId = parameter.templateId; |
|
해당 PR은 별도의 사유가 있으신게 아닌한 #86 PR과 통합 부탁드립니다, 통합간의 머지 대상 branch도 새로 신설한 dev로 변경해주시면 감사하겠습니다. |
|
#86 에 반영 |
No description provided.