Skip to content

NH-93748 Add ruff and other tox updates (redo)#682

Merged
tammy-baylis-swi merged 6 commits intomainfrom
NH-93748-update-tox-add-ruff
Aug 14, 2025
Merged

NH-93748 Add ruff and other tox updates (redo)#682
tammy-baylis-swi merged 6 commits intomainfrom
NH-93748-update-tox-add-ruff

Conversation

@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Aug 13, 2025

Replaces #681

Summary:

  1. Adds ruff which is quicker and more comprehensive for code quality management than pylint -- we're still keeping the latter for now.
  2. Removes a duplicate tox testenv, py3{9,10,11,12,13}-lambda-gh, which doesn't seem to be used anywhere.
  3. Update other tox testenv to stop installing all deps with every single run. Only does it the first time now.

I've not applied Python code changes recommended by ruff here. That will be another PR. Same with adding ruff to ci/cd.

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review August 13, 2025 23:59
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner August 13, 2025 23:59
cheempz
cheempz previously approved these changes Aug 14, 2025
Copy link
Copy Markdown
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@tammy-baylis-swi tammy-baylis-swi merged commit ee456ca into main Aug 14, 2025
64 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-93748-update-tox-add-ruff branch August 14, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants