NH-104520 Update SwPropagator class; redesign propagator config#687
Merged
tammy-baylis-swi merged 9 commits intomainfrom Sep 8, 2025
Merged
NH-104520 Update SwPropagator class; redesign propagator config#687tammy-baylis-swi merged 9 commits intomainfrom
tammy-baylis-swi merged 9 commits intomainfrom
Conversation
cheempz
reviewed
Sep 8, 2025
cheempz
approved these changes
Sep 8, 2025
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the revisit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the defaults and configuration requirements for
OTEL_PROPAGATORS.New default:
solarwinds_propagator,baggage.The only required propagator is
solarwinds_propagator.tracecontextis no longer needed and not recommended anymore, as it will repeat what newsolarwinds_propagatorwill do and introduce context conflicts. The library will log an error and agent will be disabled is users have settracecontextinOTEL_PROPAGATORenv var.The order of propagators no longer matters.
baggage(still optional) doesn't have to be beforesolarwinds_propagator. The latter has not manipulated baggage since 4.0.0 release.