NH-107164 Drop support of SW_APM_EXPORT_LOGS_ENABLED#688
Merged
tammy-baylis-swi merged 2 commits intomainfrom Sep 8, 2025
Merged
NH-107164 Drop support of SW_APM_EXPORT_LOGS_ENABLED#688tammy-baylis-swi merged 2 commits intomainfrom
tammy-baylis-swi merged 2 commits intomainfrom
Conversation
cheempz
approved these changes
Sep 8, 2025
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM but wondering what you think about making a breaking release (with the ready? API change) that also just drops support for this one entirely?
Contributor
Author
Sure @cheempz that simplifies things! Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops support of
SW_APM_EXPORT_LOGS_ENABLEDbecause it's a convenience forOTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLEDwhich is already supported. This is a small breaking change for the next release; documentation changes in ticket.Logs a special warning for the next release. In the future, it will be removed and the regular warning of "ignoring unsupported config" will be shown instead.