Always use GenAI new semconv if instrumentors support#764
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SolarWinds OpenTelemetry distro defaults to always opt into the latest GenAI semantic conventions (when supported by installed instrumentors) by extending the OTEL_SEMCONV_STABILITY_OPT_IN value.
Changes:
- Extend
SolarWindsDistro.get_semconv_opt_in()to includegen_ai_latest_experimental. - Ensure
_configure()setsOTEL_SEMCONV_STABILITY_OPT_INusing the updated opt-in string. - Update unit tests to assert the new semconv opt-in value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
solarwinds_apm/distro.py |
Updates the semconv opt-in string returned by get_semconv_opt_in() (and thus set during distro configuration). |
tests/unit/test_distro.py |
Updates expected environment variable values and the get_semconv_opt_in() unit test to match the new opt-in string. |
…erimental Agent-Logs-Url: https://github.com/solarwinds/apm-python/sessions/9b74a7bf-b2bb-486c-abd0-a7d469990d54 Co-authored-by: tammy-baylis-swi <96076570+tammy-baylis-swi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcode APM to always use GenAI new semconv. If a loaded instrumentor supports the config, then new attributes will be used instead of deprecated. Example:
gen_ai.input.messages,gen_ai.output.messages, instead of the oldgen_ai.user.messageetc.