refactor: page.tsx를 server side로 변경하고 페이지명을 추가하기#162
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors several page components to shift business logic into dedicated client-side content components and adopts Next.js Metadata for better server-side page configuration. Key changes include removing the "use client" directive from page wrappers, extracting client logic into separate content components (e.g., MyContent, ModifyContent, CommunityPageContent, etc.), and updating page titles via the new Metadata API.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/my/page.tsx | Removed client directive and delegated dynamic logic to MyContent. |
| src/app/my/modify/page.tsx | Updated to export Metadata and delegate UI logic to ModifyContent. |
| src/app/my/favorite/page.tsx | Simplified page structure by moving dynamic logic into FavoriteContent. |
| src/app/my/LoginContent.tsx & src/app/login/page.tsx | Extracted login UI and logic into LoginContent with appropriate Metadata. |
| src/app/community/[boardCode]/… | Refactored community pages to use Metadata and split client logic into separate content components. |
| src/app/application/… | Converted application pages to server-side wrappers with Metadata and extracted their complex logic into dedicated content components. |
Comments suppressed due to low confidence (2)
src/app/my/MyContent.tsx:20
- [nitpick] Consider aligning the role display values with similar components (e.g., using Korean terms such as "멘토" and "멘티") to maintain consistency across the application.
const roleDisplay = { MENTO: "Mento", MENTEE: "Mentee", };
src/app/community/[boardCode]/[postId]/page.tsx:18
- [nitpick] Consider using parseInt(params.postId, 10) instead of Number() for a more explicit conversion to an integer.
const postId = Number(params.postId);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve #160