Skip to content

refactor: page.tsx를 server side로 변경하고 페이지명을 추가하기#162

Merged
wibaek merged 9 commits intomainfrom
refactor/160-page-name
Apr 28, 2025
Merged

refactor: page.tsx를 server side로 변경하고 페이지명을 추가하기#162
wibaek merged 9 commits intomainfrom
refactor/160-page-name

Conversation

@wibaek
Copy link
Copy Markdown
Member

@wibaek wibaek commented Apr 28, 2025

solve #160

@wibaek wibaek requested a review from Copilot April 28, 2025 02:07
@wibaek wibaek self-assigned this Apr 28, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors several page components to shift business logic into dedicated client-side content components and adopts Next.js Metadata for better server-side page configuration. Key changes include removing the "use client" directive from page wrappers, extracting client logic into separate content components (e.g., MyContent, ModifyContent, CommunityPageContent, etc.), and updating page titles via the new Metadata API.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/app/my/page.tsx Removed client directive and delegated dynamic logic to MyContent.
src/app/my/modify/page.tsx Updated to export Metadata and delegate UI logic to ModifyContent.
src/app/my/favorite/page.tsx Simplified page structure by moving dynamic logic into FavoriteContent.
src/app/my/LoginContent.tsx & src/app/login/page.tsx Extracted login UI and logic into LoginContent with appropriate Metadata.
src/app/community/[boardCode]/… Refactored community pages to use Metadata and split client logic into separate content components.
src/app/application/… Converted application pages to server-side wrappers with Metadata and extracted their complex logic into dedicated content components.
Comments suppressed due to low confidence (2)

src/app/my/MyContent.tsx:20

  • [nitpick] Consider aligning the role display values with similar components (e.g., using Korean terms such as "멘토" and "멘티") to maintain consistency across the application.
const roleDisplay = { MENTO: "Mento", MENTEE: "Mentee", };

src/app/community/[boardCode]/[postId]/page.tsx:18

  • [nitpick] Consider using parseInt(params.postId, 10) instead of Number() for a more explicit conversion to an integer.
const postId = Number(params.postId);

@wibaek wibaek merged commit 2a90e7d into main Apr 28, 2025
@manNomi manNomi deleted the refactor/160-page-name branch December 10, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants