-
Notifications
You must be signed in to change notification settings - Fork 4
fix : qa 사항 반영했습니다 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix : qa 사항 반영했습니다 #260
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
677a7c1
fix : post에서 setting 버튼 안나오는 버그 수정했습니다
9c0b0ce
fix : 지원 목록 불러오기 실패시 지원하기 페이지로 이동하도록 수정했습니다
8b2bfe0
fix : 지원완료 페이지 수정했습니다
cb7612a
fix : 검색 페이지 수정했습니다
d509661
refactor : 스피너 위치 수정했습니다
4a0cc16
fix : 검색 이후 경로 수정했습니다
efe0de0
fix : 애러 처리 핸들링 수정했습니다
4f4d4f3
fix : 대학 증복되는 버그 수정했습니다
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { Metadata } from "next"; | ||
|
|
||
| import TopDetailNavigation from "@/components/layout/TopDetailNavigation"; | ||
|
|
||
| import SchoolSearchForm from "./PageContent"; | ||
| import SearchBar from "./SearchBar"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "파견 학교 목록", | ||
| }; | ||
|
|
||
| const Page = async () => { | ||
| return ( | ||
| <> | ||
| <TopDetailNavigation title="파견학교 검색" /> | ||
| <main className="flex flex-1 flex-col p-5"> | ||
| <h2 className="mb-1 text-2xl font-bold">오직 나를 위한</h2> | ||
| <h2 className="mb-6 text-2xl font-bold">맞춤 파견 학교 찾기</h2> | ||
| <div className="relative mb-4"> | ||
| <SearchBar /> | ||
| </div> | ||
| <SchoolSearchForm /> | ||
| </main> | ||
| </> | ||
| ); | ||
| }; | ||
|
|
||
| export default Page; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
1) 컴포넌트명 변경에 따른 정합성 확보: 파일명(SearchBar.tsx) vs. 기본 export(SearchForm).
이름 불일치로 import 경로/자동 리팩토링에서 혼동 여지가 큽니다. 파일명을 SearchForm.tsx로 바꾸거나, 컴포넌트/기본 export를 SearchBar로 되돌리는 두 가지 중 하나로 정리해주세요.
아래 중 “B안”은 코드만으로 해결됩니다.
레포 내 사용처 점검 스크립트:
🏁 Script executed:
Length of output: 2088
스크립트 내부 정규식 따옴표 오류를 수정하고,
SearchBar와SearchForm의 사용처를 정확히 재확인하기 위해 아래 스크립트를 실행해 주세요.🏁 Script executed:
Length of output: 3685
컴포넌트명과 파일명 일치화 제안
파일명 변경 제안
SearchBar.tsx를 SearchForm.tsx로 변경해 파일명과 기본 export(컴포넌트명)를 동기화합니다.
컴포넌트명 변경 제안
src/app/university/SearchBar.tsx 내부 컴포넌트 및 export를 SearchForm에서 SearchBar로 수정해 파일명과 일치시킵니다.
📝 Committable suggestion
🤖 Prompt for AI Agents