Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

fix/NSS#1208#6

Merged
jaxoncreed merged 4 commits intosolid-contrib:masterfrom
jaxoncreed:fix/NSS#1208
Jun 12, 2019
Merged

fix/NSS#1208#6
jaxoncreed merged 4 commits intosolid-contrib:masterfrom
jaxoncreed:fix/NSS#1208

Conversation

@jaxoncreed
Copy link
Copy Markdown
Contributor

@jaxoncreed jaxoncreed commented May 30, 2019

Copy link
Copy Markdown
Contributor

@RubenVerborgh RubenVerborgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, total hack of course, but then again this entire library is.

Comment thread src/SolidClient.js
Comment thread src/SolidClient.js Outdated
Comment thread src/SolidClient.js Outdated
Comment thread src/SolidClient.js
@jaxoncreed
Copy link
Copy Markdown
Contributor Author

Okay this is now good to merge @RubenVerborgh

@jeff-zucker
Copy link
Copy Markdown
Member

Just to confirm, I was able to get this from a test script with this branch:

logged in as <https://jeffzucker.dev.inrupt.net/profile/card#me>
Ok GET public resource from solid-server/5.1.3
Ok PUT resource in private container.

@RubenVerborgh
Copy link
Copy Markdown
Contributor

Thanks @jaxoncreed and @jeff-zucker.

@jaxoncreed Do you want to become a maintainer of the package? Then I'd give you the right permissions for merging and npm publishing. If you prefer not to, I can follow up.

@jaxoncreed
Copy link
Copy Markdown
Contributor Author

@RubenVerborgh Sure. I can take that on.

@jeff-zucker
Copy link
Copy Markdown
Member

👍 It will be great to have someone on the server side managing this :-). Please count on me for any testing or other help you need.

@RubenVerborgh
Copy link
Copy Markdown
Contributor

It will be great to have someone on the server side managing this :-)

Hey hey, I've done server work 😛 But not lately indeed.

Please count on me for any testing or other help you need.

Excellent, thanks!

@jeff-zucker
Copy link
Copy Markdown
Member

I've done server work

Ha, yes, I'm sure you have. I just meant that given such strong (and in the long run inappropriate) binding of app and server, it will be good to have the catching designed by someone who does the pitching :-).

@jaxoncreed jaxoncreed merged commit 9d41f25 into solid-contrib:master Jun 12, 2019
@jaxoncreed
Copy link
Copy Markdown
Contributor Author

@RubenVerborgh Could I also have npm access to this? My username is the same (jaxoncreed)

@jeff-zucker
Copy link
Copy Markdown
Member

@jaxoncreed, if you npm it, please include #5, otherwise rdflib will continue to show vulnerabilities.

@RubenVerborgh
Copy link
Copy Markdown
Contributor

@jaxoncreed Best to have access to the entire @solid group in npm; Inrupt can help you with that.

@jaxoncreed
Copy link
Copy Markdown
Contributor Author

@jeff-zucker absolutely. Good catch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants