Conversation
csarven
reviewed
Jun 3, 2022
csarven
reviewed
Jun 3, 2022
| Given url childContainerUrl | ||
| And headers clients.alice.getAuthHeaders('PUT', childContainerUrl) | ||
| And header Content-Type = 'text/turtle' | ||
| And header Link = '<http://www.w3.org/ns/ldp#BasicContainer>; rel="type"' |
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
I hadn't spotted that PUT with "/" just doesn't need the link since it is implied. I will remove that but I'll add equivalent tests for POST.
csarven
approved these changes
Jun 3, 2022
Collaborator
csarven
left a comment
csarven
left a comment
There was a problem hiding this comment.
Not sure why my comments got out there before I started to review. Any way.. okay to merge. Should there be more tests - am I overlooking? - where e.g. POST / (with Link rel=LDBC) creates non-container ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.