Skip to content

fix: disabled removabled when selected or toggleable#2682

Closed
martascorreia wants to merge 4 commits intonextfrom
fix/removable-attribute-on-sd-tag
Closed

fix: disabled removabled when selected or toggleable#2682
martascorreia wants to merge 4 commits intonextfrom
fix/removable-attribute-on-sd-tag

Conversation

@martascorreia
Copy link
Copy Markdown
Contributor

@martascorreia martascorreia commented Jan 7, 2026 •
edited
Loading

Description:

Closes: #2398.

Added a variable isRemovable to the sd-tag component. This variable represents the removable attribute being enabled, while checking if the toggleable or selected attributes are disabled. Then, replaced every place that checked if the removable attribute was enabled for this new variable.

Also added a note to the docs about this. Let me know if it is enough or if we should create more emphasis.

Definition of Reviewable:

  • Documentation is created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 7, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: ffa27e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "@solid-design-system/components" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/styles" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/tokens" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@martascorreia martascorreia self-assigned this Jan 7, 2026
@martascorreia martascorreia moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Jan 7, 2026
@martascorreia martascorreia moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Jan 7, 2026
@martascorreia martascorreia linked an issue Jan 7, 2026 that may be closed by this pull request
fix: 🤔 disallow removable on sd-tag when it has toggleable or selected #2398
Closed
4 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 7, 2026 •
edited
Loading

🚀 Storybook has been deployed for branch fix_removable-attribute-on-sd-tag

@martascorreia martascorreia moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Jan 7, 2026
@MartaPintoTeixeira
Copy link
Copy Markdown
Contributor

MartaPintoTeixeira commented Jan 14, 2026

Docs updated in design, following code. If something changes please leave me a comment in figma. thanks

@mariohamann mariohamann changed the title fix: disabled removabled when selected ot toggleable fix: disabled removabled when selected or toggleable Jan 15, 2026
mariohamann
mariohamann requested changes Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mariohamann mariohamann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests. (Just that there is only no button when removable and selected is active or similar.)

@martascorreia martascorreia moved this from 👀 In review to 🏗 In progress in Solid Design System Project Board Jan 15, 2026
@martascorreia martascorreia mentioned this pull request Jan 22, 2026
Merged
2 tasks
@github-project-automation github-project-automation Bot moved this from 🏗 In progress to ✅ Done in Solid Design System Project Board Jan 22, 2026
martascorreia added a commit that referenced this pull request Jan 30, 2026
@martascorreia @smfonseca
fix: disabled removabled when selected or toggleable (#2759)
909bef6 
## Description:
Closes: #2398.
Previous PR: #2682

Added a variable _isRemovable_ to the sd-tag component. This variable
represents the _removable_ attribute being enabled, while checking if
the _toggleable_ or _selected_ attributes are disabled. Then, replaced
every place that checked if the removable attribute was enabled for this
new variable.

Also added a note to the docs about this. Let me know if it is enough or
if we should create more emphasis.


## Definition of Reviewable:
- [x] Documentation is created/updated
- [x] relevant tickets are linked

---------

Co-authored-by: Sérgio Fonseca <42741644+smfonseca@users.noreply.github.com>
@martascorreia martascorreia deleted the fix/removable-attribute-on-sd-tag branch February 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariohamann mariohamann mariohamann approved these changes

@MartaPintoTeixeira MartaPintoTeixeira MartaPintoTeixeira approved these changes

Assignees

@martascorreia martascorreia

Labels

None yet

Projects

Solid Design System Project Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: 🤔 disallow removable on sd-tag when it has toggleable or selected

6 participants

@martascorreia @MartaPintoTeixeira @mariohamann @smfonseca @balco0110 @auroraVasconcelos