Skip to content

fix: versioned sd-input validation#2817

Merged
smfonseca merged 3 commits intomainfrom
fix/versioned-sd-input-validation
Mar 3, 2026
Merged

fix: versioned sd-input validation#2817
smfonseca merged 3 commits intomainfrom
fix/versioned-sd-input-validation

Conversation

@smfonseca
Copy link
Copy Markdown
Collaborator

Description:

Current versioning script was also changing events inside of the assumeInteractionOn array on the form controller. With this fix, we introduce a more robust strategy to identify patterns that should not be versioned.

Original build output:

Screenshot 2026-02-26 at 13 16 56

Build output with fixed versioning:

Screenshot 2026-02-26 at 13 18 21

Versioned sd-input validation with fixed build output:

Screen.Recording.2026-02-26.at.16.44.33.mov

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 26, 2026

🦋 Changeset detected

Latest commit: ebf5a36

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@solid-design-system/components" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/styles" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@solid-design-system/tokens" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@smfonseca smfonseca changed the title fix: versioned sd input validation fix: versioned sd-input validation Feb 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch fix_versioned-sd-input-validation

@smfonseca smfonseca merged commit 6311a4e into main Mar 3, 2026
19 of 20 checks passed
@smfonseca smfonseca deleted the fix/versioned-sd-input-validation branch March 3, 2026 10:27
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants