Skip to content

Bugfix https://github.com/solid-software/flutter_vlc_player/issues/52 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solid-software merged 5 commits into from
May 26, 2020
Merged

Bugfix https://github.com/solid-software/flutter_vlc_player/issues/52 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c94c8dd
Merge pull request #1 from solid-software/master
mitchross May 19, 2020
f2a2429
Bugfix for https://github.com/solid-software/flutter_vlc_player/issue…
mitchross May 24, 2020
c785f18
spec bump
mitchross May 24, 2020
0ee1d61
Merge pull request #2 from solid-software/master
mitchross May 24, 2020
c5629d9
changelog
mitchross May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.0.1
* Fix a bug on Android with URL parsing. See (https://github.com/solid-software/flutter_vlc_player/issues/52),
credits to pharshdev (https://github.com/pharshdev) and Mitch Ross (https://github.com/mitchross)

## 3.0.0
* Migrated to Swift, thanks to Mitch Ross (https://github.com/mitchross),
Amadeu Cavalcante (https://github.com/amadeu01) and pharshdev (https://github.com/pharshdev).
Expand Down
4 changes: 2 additions & 2 deletions android/src/main/java/software/solid/fluttervlcplayer/FlutterVideoView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public void onMethodCall(MethodCall methodCall, @NonNull MethodChannel.Result re
vout.attachViews();

String initStreamURL = methodCall.argument("url");
Media media = new Media(libVLC, Uri.parse(Uri.decode(initStreamURL)));
Media media = new Media(libVLC, Uri.parse(initStreamURL));
mediaPlayer.setMedia(media);

result.success(null);
Expand All @@ -178,7 +178,7 @@ public void onMethodCall(MethodCall methodCall, @NonNull MethodChannel.Result re

mediaPlayer.stop();
String newURL = methodCall.argument("url");
Media newMedia = new Media(libVLC, Uri.parse(Uri.decode(newURL)));
Media newMedia = new Media(libVLC, Uri.parse(newURL));
mediaPlayer.setMedia(newMedia);

result.success(null);
Expand Down
2 changes: 1 addition & 1 deletion example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.6.1'
classpath 'com.android.tools.build:gradle:3.6.3'
}
}

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_vlc_player
description: A VLC-powered alternative to Flutter's video_player. Supports multiple players on one screen.
version: 3.0.0
version: 3.0.1
homepage: https://github.com/solid-software/flutter_vlc_player

environment:
Expand Down