perf(coreNode): split children update loop on childUpdateType#15
Merged
Conversation
The inner loop had a per-iter `if (childUpdateType !== 0)` compare even though that value is invariant across the loop. Split into two specialized loops based on whether childUpdateType is zero — saves one compare per child per frame, which adds up for nodes with many children. Behavior is identical to the previous combined loop; two unit tests lock in the contract for both branches: - inherited childUpdateType cascades into children whose updateType was 0 - with no inherited bits, only children with pending work are walked Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The children update loop in
CoreNode.updatehad a per-iterationif (childUpdateType !== 0)compare even though that value is invariant across the loop. Split it into two specialized loops based on whetherchildUpdateTypeis zero — one fewer compare per child per frame, which adds up for nodes with many children.Behavior is identical to the previous combined loop.
Test plan
pnpm test— 146/146 passingpnpm build— cleanchildUpdateTypecascades into children whoseupdateTypewas 0🤖 Generated with Claude Code