Skip to content

fix: bordered shaders precision with asymmetric borders #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chiefcll merged 1 commit into from
May 19, 2026
Merged

fix: bordered shaders precision with asymmetric borders #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/core/shaders/webgl/Border.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,12 @@ export const Border: WebGlShaderType<BorderProps> = {
vec2 screenSpace = vec2(2.0 / u_resolution.x, -2.0 / u_resolution.y);
vec2 edge = clamp(a_nodeCoords * 2.0 - vec2(1.0), -1.0, 1.0);

float borderTop = u_borderWidth.x;
float borderRight = u_borderWidth.y;
float borderBottom = u_borderWidth.z;
float borderLeft = u_borderWidth.w;
vec4 adjustedBorderWidth = u_borderWidth - 1.0 + clamp(u_borderWidth, -1.0, 1.0);

float borderTop = adjustedBorderWidth.x;
float borderRight = adjustedBorderWidth.y;
float borderBottom = adjustedBorderWidth.z;
float borderLeft = adjustedBorderWidth.w;

v_outerBorderUv = vec2(0.0);
v_innerBorderUv = vec2(0.0);
Expand Down
10 changes: 6 additions & 4 deletions src/core/shaders/webgl/RoundedWithBorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,12 @@ export const RoundedWithBorder: WebGlShaderType<RoundedWithBorderProps> = {
v_outerSize = vec2(0.0);

if(borderZero == 0.0) {
float borderTop = u_borderWidth.x;
float borderRight = u_borderWidth.y;
float borderBottom = u_borderWidth.z;
float borderLeft = u_borderWidth.w;
vec4 adjustedBorderWidth = u_borderWidth - 1.0 + clamp(u_borderWidth, -1.0, 1.0);

float borderTop = adjustedBorderWidth.x;
float borderRight = adjustedBorderWidth.y;
float borderBottom = adjustedBorderWidth.z;
float borderLeft = adjustedBorderWidth.w;

v_outerBorderUv = vec2(0.0);
v_innerBorderUv = vec2(0.0);
Expand Down
10 changes: 6 additions & 4 deletions src/core/shaders/webgl/RoundedWithBorderAndShadow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,12 @@ export const RoundedWithBorderAndShadow: WebGlShaderType<RoundedWithBorderAndSha
v_outerSize = vec2(0.0);

if(borderZero == 0.0) {
float borderTop = u_borderWidth.x;
float borderRight = u_borderWidth.y;
float borderBottom = u_borderWidth.z;
float borderLeft = u_borderWidth.w;
vec4 adjustedBorderWidth = u_borderWidth - 1.0 + clamp(u_borderWidth, -1.0, 1.0);

float borderTop = adjustedBorderWidth.x;
float borderRight = adjustedBorderWidth.y;
float borderBottom = adjustedBorderWidth.z;
float borderLeft = adjustedBorderWidth.w;

v_outerBorderUv = vec2(0.0);
v_innerBorderUv = vec2(0.0);
Expand Down
Loading