fix(webgl): upload SDF buffer in renderRTT#38
Merged
Conversation
…ramebuffers renderRTT() uploaded the regular quad buffer but not the shared SDF text buffer, so SdfRenderOp.draw() ran drawElements against stale GPU vertex data for any text rendered into an RTT framebuffer. Mirror the upload that render() already performs for the main scene. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ocker The script set RUNTIME_ENV=ci but never passed --ci, so it skipped dockerCiMode() and tried to capture snapshots on the host. The container re-invokes pnpm test:visual with RUNTIME_ENV=ci itself, so the env var on the host command was redundant anyway. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebGlRenderer.renderRTT()uploaded the regular quad buffer to the GPU but skipped the shared SDF text buffer, soSdfRenderOp.draw()randrawElementsagainst stale (or empty) vertex data for any text rendered into an RTT framebuffer. Colored quads worked because they use the separaterttQuadBufferpath that was already being uploaded. Mirrors the SDF buffer upload that the main scene'srender()already performs (WebGlRenderer.ts:976) insiderenderRTT()(WebGlRenderer.ts:1221).pnpm test:visual:update-cisetRUNTIME_ENV=cibut never passed--ci, so it skippeddockerCiMode()and tried to capture snapshots on the host. Pass--ciinstead — the container re-invokespnpm test:visualwithRUNTIME_ENV=ciitself, so the host-side env var was redundant.Test plan
pnpm testpnpm test:visual:update-cifrom the repo root re-launches in docker (no longer runs on the host).🤖 Generated with Claude Code