Skip to content

row transitions #8

@chiefcll

Description

@chiefcll

handleNavigation overwrites el.transition at runtime

When a user navigates left or right, handleNavigation.js directly mutates el.transition by spreading el.transitionLeft or transitionRight over it. Because Row passes defaultTransitionBack and defaultTransitionForward to those props by default, it silently overwrites any custom inline transition the developer provided the moment they press a navigation key.
(Current workaround: We have to manually pass custom transitionLeft and transitionRight props to match the main transition).

Transitions from the style object are completely ignored

The Row component sets an empty object transition={/* @once */{}} as an explicit prop before spreading user props. Down in elementNode.js, the style setter skips applying any style key if this[key] is not undefined (to prioritize JSX props). Since this.transition is already {} from the Row's JSX, any transition defined in the style object gets skipped entirely.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions