Updated login auth to use ldo-solid-react#36
Merged
PreciousOritsedere merged 17 commits intomainfrom Dec 10, 2025
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Co-authored-by: jeswr <63333554+jeswr@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
PreciousOritsedere
requested review from
hkir-dev,
jeswr,
langsamu and
matthieubosquet
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jeswr
approved these changes
Dec 9, 2025
| const [isChecking, setIsChecking] = useState(true); | ||
| const [error, setError] = useState<Error | null>(null); | ||
| // Check if there's any indication of a session in storage | ||
| function hasSessionInStorage(): boolean { |
Member
There was a problem hiding this comment.
Is this required? I would have thought you could observe state change of the session object in the getSolidLogin hook
| @@ -0,0 +1,39 @@ | |||
| # Root ACR for the agent account | |||
Member
There was a problem hiding this comment.
Did you intend to add these artefacts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also resolved merge conflict