Ditching antlr4ts #103
Merged
Ditching antlr4ts #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janther
force-pushed
the
ditching_antlr4ts
branch
2 times, most recently
from
b84b4db to
7322745
Compare
Janther
force-pushed
the
ditching_antlr4ts
branch
from
7322745 to
9975828
Compare
… can afford a slight increase in the final output
fvictorio
reviewed
Dec 21, 2023
Contributor
fvictorio
left a comment
fvictorio
left a comment
There was a problem hiding this comment.
Thanks a lot for this, I didn't know that there was an official typescript target now!
| - name: Install | ||
| run: npm install | ||
| - name: Install ANTLR4 | ||
| run: pip install antlr4-tools |
Contributor
There was a problem hiding this comment.
Do you mind updating the https://github.com/solidity-parser/parser/blob/master/DEVELOPING.md document? I know it wasn't up to date to begin with, but I think it would be a good idea to do it now that we (again) use something other than npm.
Also, I think we can remove the scripts/antlr.sh file (mentioned in that outdated document).
| sourcemap: true, | ||
| format: 'cjs', | ||
| platform: 'node', | ||
| target: 'node16', |
Contributor
There was a problem hiding this comment.
Good catch, I hadn't updated this in a while.
…build on prettier-plugin-solidity
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
antlr4tsthat hasn't been updated in 3 years and relying in the officialantlr4Typescript target.Main changes.
arrayare now prepended by_listundefinednow generated functions returnnulllocandrangeattributes follow the naming standardSome details:
src/ASTBuilder.tshas a check forErrorNodebutantlr4doesn't expose this class nor is this check triggered in any tests.import.meta.urlthat is wrongly processed byesbuildThe built size is cut in half thanks to this.