Added separate Solid 2 vitest config#897
Merged
davedbase merged 2 commits intoMay 14, 2026
Merged
Conversation
|
atk
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
configs/vitest.config.solid2.ts— a shared Vitest config using a direct Babel +babel-preset-solid@2.0.0-beta.12transform instead ofvite-plugin-solid, needed for packages whose tests use JSX with the Solid 2.0@solidjs/webruntime (e.g.<For>children are now accessors)@babel/coreandbabel-preset-solid@2.0.0-beta.12to rootdevDependenciessoconfigs/vitest.config.solid2.tsresolves the correct preset (root previously only had1.xviavite-plugin-solid)vitest2/test:client2/test:ssr2scripts to rootpackage.json, the package template, andpackages/virtual— Solid 2.0 packages with JSX tests pointtest/test:ssratvitest2; everything else keepsvitestWhy a separate config?
vite-plugin-solidbundlesbabel-preset-solid@1.x, which generates the_$effect(compute, apply)two-argument form incompatible with the Solid 2.0 runtime. The new config callsbabel-preset-soliddirectly withmoduleName: "@solidjs/web", producing correct output. Only packages with actual JSX in tests need this — the 20+ other already-migrated primitives use plain.tstests and keep working with the existing config.