Merged
Conversation
StalkAltan
commented
Aug 9, 2021
Comment on lines
+7
to
+11
| { | ||
| "targets": { | ||
| "node": "current" | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
This resolves an issue where running Jest results in ReferenceError: regeneratorRuntime is not defined.
StalkAltan
commented
Aug 9, 2021
| ...shared, | ||
| // uses a webpack style resolver, the default one has many issues. | ||
| resolver: require.resolve("./resolver"), | ||
| testEnvironment: 'jsdom', |
Author
There was a problem hiding this comment.
In Jest 27, jsdom is no longer the default test environment, so we need to specify it here.
StalkAltan
commented
Aug 9, 2021
| const babelJest = require("babel-jest"); | ||
|
|
||
| module.exports = babelJest.createTransformer({ | ||
| module.exports = babelJest.default.createTransformer({ |
Author
There was a problem hiding this comment.
In babel-jest 27, createTransformer is now exposed via a default export.
Member
|
This all looks great thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for jest 27. There are some slight changes that required tweaks.
The goal of this is to 1) keep these presets up to date, and 2) support using Jest/Solid within Nx workspaces.
I've added comments to the various changes with rationale. I didn't bump the package version in the package.json because I don't know how the team would like this to move.
Once this package supports Jest 27, all that is needed for
solid-testing-libraryto also support that version is bumping the package.json :)