You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The active/inactive classes don't apply correctly for URL's containing international characters, as the location is URL-encoded while the path passed to the component is not. This is one way to make it work, the alternatives being to encode the path coming in, or to decode the location everywhere (which I would personally like to see but would be a larger change). Not sure which is preferred.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
I'm not sure which is prefered either. I feel like we tried some encode/decode stuff previously and it got us in trouble. But I am definitely open to finding the right solution. This is easy enough for now but I do wonder if we will find more issues unless we solve this systematically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active/inactive classes don't apply correctly for URL's containing international characters, as the location is URL-encoded while the path passed to the component is not. This is one way to make it work, the alternatives being to encode the path coming in, or to decode the location everywhere (which I would personally like to see but would be a larger change). Not sure which is preferred.