refactor: avoid nested h3 defineHandler call in createBaseHandler #2006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
To decorate the handler and all middleware with FetchEvent, h3's
defineHandleris wrapped in anotherdefineHandler. This is not conforming with h3's intended API usage.What is the new behavior?
Instead the handler and each middleware are decorated separately. This shouldn't change any behavior, but follows h3's usage patterns closer and hopefully reduces the chance of future related bugs.
More info
The old code was introduced during the devinxi work.