Skip to content

Conversation

@katywings
Copy link
Contributor

What is the current behavior?

To decorate the handler and all middleware with FetchEvent, h3's defineHandler is wrapped in another defineHandler. This is not conforming with h3's intended API usage.

What is the new behavior?

Instead the handler and each middleware are decorated separately. This shouldn't change any behavior, but follows h3's usage patterns closer and hopefully reduces the chance of future related bugs.

More info

The old code was introduced during the devinxi work.

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

⚠️ No Changeset found

Latest commit: 95c6d24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for solid-start-landing-page failed. Why did it fail? →

Name Link
🔨 Latest commit 95c6d24
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/691cb47f4614490007d4c9f8

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2006

commit: 95c6d24

Copy link
Contributor

@brenelz brenelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me

@atilafassina atilafassina merged commit 5f19f92 into main Nov 19, 2025
5 of 9 checks passed
@atilafassina atilafassina deleted the refactor-provide-request-event branch November 19, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants