Skip to content

Cleanups, better build pipeline and publish as common js#1

Merged
ryansolid merged 5 commits intosolidjs:mainfrom
amoutonbrady:main
Feb 16, 2021
Merged

Cleanups, better build pipeline and publish as common js#1
ryansolid merged 5 commits intosolidjs:mainfrom
amoutonbrady:main

Conversation

@amoutonbrady
Copy link
Copy Markdown
Member

This PR aims to:

  • Cleanups the source by extracting types into their own files and cleaning up the code to make TS happy
  • Make tsconfig.json observe the tests files for linting errors
  • Make a tsconfig.build.json to build only the source file and exclude tests
  • Compile the source to commonjs. Jest runs on node and doesn't understand import (as far as I tested on another project). I believe this is what's happening here: https://github.com/testing-library/preact-testing-library/blob/master/.babelrc#L7

@amoutonbrady
Copy link
Copy Markdown
Member Author

Just checking in the tests seems to pass just fine, I think the 12k diff of the lockfile is due to the version. The initially commited one was probably made with npm < 7 whereas I made mine with npm > 7. If this is an issue I can quickly change my node version and regenerate a clean v1 lock file.

@ryansolid
Copy link
Copy Markdown
Member

Thank you I was going to set up an example today as it was so late last night when I finished up the test suite. Completely missed on the CommonJS. Thanks.

@ryansolid ryansolid merged commit fe0d0fa into solidjs:main Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants