Skip to content

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Oct 29, 2024

I noticed a test is breaking.

This should prevent that from happen going forward

@birkskyum birkskyum changed the title Add github CI workflow Add github CI Test workflow Oct 29, 2024
@LadyBluenotes
Copy link
Member

@thetarnav can you review please?

Copy link
Contributor

@thetarnav thetarnav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good, probably would bump the node version to 22 now but whatever, the library is on old versions anyway.

@birkskyum birkskyum merged commit fc51a31 into solidjs:main Sep 7, 2025
@birkskyum
Copy link
Member Author

Update to node 22 in CI in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants