Compatiblity with happy-dom

[dairyisscary]

Hello solid folks! Hope you're doing well. As a side note, Ryan, I watch your Friday streams religiously and I must admit I've found them very insightful.

Currently, I'm bootstrapping a new solid js project and I'm using jest and solid-testing-libary with the jsdom environment to write tests. I wanted to try out the alternative DOM implementation happy-dom but I ran into this issue:

    TypeError: Cannot set property currentTarget of #<MouseEvent> which has only a getter

      21 |     expectIsChecked(switchElement, false);
      22 |
    > 23 |     userEvent.click(switchElement);
         |               ^
      24 |     expectIsChecked(switchElement, true);
      25 |
      26 |     // can be changed externally

      at Window.EventTarget.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/event/EventTarget.ts:53:22)
      at HTMLDocument.Document.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/nodes/document/Document.ts:700:28)
      at HTMLElement.Node.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/nodes/node/Node.ts:400:28)
      at HTMLElement.Node.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/nodes/node/Node.ts:400:28)
      at HTMLElement.Node.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/nodes/node/Node.ts:400:28)
      at HTMLElement.Node.dispatchEvent (../../node_modules/.pnpm/happy-dom@2.30.1/node_modules/happy-dom/src/nodes/node/Node.ts:400:28)
      at ../../node_modules/.pnpm/@testing-library+dom@7.31.2/node_modules/@testing-library/dom/dist/events.js:25:20
      at Object.eventWrapper (../../node_modules/.pnpm/@testing-library+dom@7.31.2/node_modules/@testing-library/dom/dist/config.js:27:23)
      at fireEvent (../../node_modules/.pnpm/@testing-library+dom@7.31.2/node_modules/@testing-library/dom/dist/events.js:16:35)
      at Function.click (../../node_modules/.pnpm/@testing-library+dom@7.31.2/node_modules/@testing-library/dom/dist/events.js:106:36)
      at Object.<anonymous> (src/switch/index.test.tsx:23:15)
      at TestScheduler.scheduleTests (../../node_modules/.pnpm/@jest+core@27.4.7/node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (../../node_modules/.pnpm/@jest+core@27.4.7/node_modules/@jest/core/build/runJest.js:404:19)
      at _run10000 (../../node_modules/.pnpm/@jest+core@27.4.7/node_modules/@jest/core/build/cli/index.js:320:7)
      at runCLI (../../node_modules/.pnpm/@jest+core@27.4.7/node_modules/@jest/core/build/cli/index.js:173:3)

it appears this is caused by this line in dom-expressions https://github.com/ryansolid/dom-expressions/blob/95668430dc4bd0b4d4836ee6f03568841085caed/packages/dom-expressions/src/client.js#L301

happy-dom is doing an assignment to currentTarget during event dispatch (i guess jsdom, which works fine, doesn't do this).

Is this a bug? as far as I can tell, the DOM spec, currentTarget should be writable. I monkeypatched my local solid-js/web module with a setter like

set(newNode) {
  node = newNode;
},

which made my tests pass.

[atk]

This is actually rather an error in happy-dom, because currentTarget is supposed to be read-only: https://dom.spec.whatwg.org/#interface-event

Update: I filed an issue with happy-dom.

[dairyisscary]

Oh wow, so fast, @atk! Thanks! I'm not sure where I read that it's writable now, and I feel silly. Happy weekend!

For everyone's reference, or those coming from google capricorn86/happy-dom#343