improve error handling in untrack

[mdynnl]

addresses #1323

[coveralls]

Pull Request Test Coverage Report for Build 3396731709

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 89.155%

---

Totals
Change from base Build 3354507218:	0.0%
Covered Lines:	1282
Relevant Lines:	1368

---

💛 - Coveralls

[mdynnl]

what about

solid/packages/solid/src/reactive/signal.ts

Lines 971 to 1000 in 763adf4

	export function startTransition(fn: () => unknown): Promise<void> {
	if (Transition && Transition.running) {
	fn();
	return Transition.done!;
	}
	const l = Listener;
	const o = Owner;
	return Promise.resolve().then(() => {
	Listener = l;
	Owner = o;
	let t: TransitionState | undefined;
	if (Scheduler || SuspenseContext) {
	t =
	Transition ||
	(Transition = {
	sources: new Set(),
	effects: [],
	promises: new Set(),
	disposed: new Set(),
	queue: new Set(),
	running: true
	});
	t.done || (t.done = new Promise(res => (t!.resolve = res)));
	t.running = true;
	}
	runUpdates(fn, false);
	Listener = Owner = null;
	return t ? t.done : undefined;
	});
	}

especially

solid/packages/solid/src/reactive/signal.ts

Line 973 in 763adf4

fn();

should this go through solid's error handling?

[ryansolid]

That one's probably fine. If the Transition is running it means it is running in a runUpdate further up. The problem with untrack is it messes with Listener/Owner and misses restoring it if it throws. Where this is handled higher up.

[coveralls]

Pull Request Test Coverage Report for Build 3396731709

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 89.155%

---

Totals
Change from base Build 3354507218:	0.0%
Covered Lines:	1282
Relevant Lines:	1368

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 3396731709

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 89.155%

---

Totals
Change from base Build 3354507218:	0.0%
Covered Lines:	1282
Relevant Lines:	1368

---

💛 - Coveralls