You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
I was working on the 2.0 branch and saw HMR appeared broken because of changes made here. We should confirm that. I'm going to patch something for 2.0 for now. But @lxsmnsyc we probably need to review what the proper fix is for refresh 0.7 before merging this. I'm not sure the intention but AI reported:
Root cause: Commit ad30cba ("fix #22") deleted get-vite-hmr-requirement.ts which generated import.meta.hot.accept() in the module code. The rationale was that $$refreshESM already calls hot.accept() at runtime. However, Vite's server-side importAnalysis plugin statically lexes the transformed source for the literal pattern import.meta.hot.accept (see Vite source line ~30034) to mark modules as isSelfAccepting. Without it, Vite sends full-reload instead of hot-update.
The decline path (get-hmr-decline-call.ts:11-30) still emits import.meta.hot.accept() directly for Vite -- only the normal refresh path lost it.
If Vite changed their import analysis again I'll probably have to revert that change, will check again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.