Added the ability to disable group similar time entries#1054
Added the ability to disable group similar time entries#1054Onatcer merged 6 commits intosolidtime-io:mainfrom
Conversation
|
thanks for the contribution. a few notes:
|
|
i just realized the TimeEntryMassActionRow is used in the Reporting as well. We can just add a "settings" slot to the component and only pass it in Time.vue. The useStorage can stay in the main application then and can be passed down like the PR already does. |
|
Alright, I’ll try to move the setting closer to the Time view. I’ll also adjust how storage is handled (key, naming, extracting it into a separate file) and replace the ternary with a more readable early return. Regarding the tests — without Observations by case:
I agree that waiting by timeout is more of a workaround, but I was not able to find a stable alternative based on waiting for specific states. I’m not very familiar with writing Playwright tests, so I might be missing a better approach here. |
|
I got some time to work on this and took a closer look at Regarding
|
|
I agree that the MassEditRow in the Time view has problems, specifically that it can be out of the viewport when selecting time entries and that "Select All" is not a useful scope for an infinite scroll page. I'm honestly not a big fan of the approach that Clockify and Toggl are doing either tho, because everything is day scoped you'd need multiple bulk actions to edit time entries across days. maybe I'm missing something but i think dropping the select all on the time page and having a sticky MassActionBar at top when entries are selected is a better way to handle it. Selecting all time entries of a day is already possible via the TimeEntryRowHeader. Having the Edit and Delete Actions directly in the header adds ambiguity imo because as soon as time entries from multiple days are selected, it's not really clear anymore what the bulk actions are performed on. The component is also used int he Detailed reporting where it works from a UX perspective imo. But really this is a separate discussion, I created one here to discuss this. For this PR I'm fine with keeping it in the Profile Settings. |
… into a dedicated module
…waits and assertions
|
Most feedback has been addressed in the latest commits:
For the setting placement, we agreed to keep it in Profile Settings for now. |
|
LGTM, thank you for the contribution! |
What does this PR do?
Adds the ability to disable grouping similar time entries. #445
Checklist (DO NOT REMOVE)