Move UserClassHandle to lib/#3813
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom Dec 14, 2020
Merged
Conversation
elia
force-pushed
the
elia/dont-autoload-user-class-handle
branch
from
78dd620 to
da04d68
Compare
elia
force-pushed
the
elia/dont-autoload-user-class-handle
branch
from
da04d68 to
0dc4498
Compare
This class is potentially loaded during initialization when used by factories and that can generate problems with reloaders. In Rails 6 / zeitwerk that resulted in this warning message: ``` DEPRECATION WARNING: Initialization autoloaded the constant Spree::UserClassHandle. Being able to do this is deprecated. Autoloading during initialization is going to be an error condition in future versions of Rails. Reloading does not reboot the application, and therefore code executed during initialization does not run again. So, if you reload Spree::UserClassHandle, for example, the expected changes won't be reflected in that stale Class object. This autoloaded constant has been unloaded. Please, check the "Autoloading and Reloading Constants" guide for solutions. (called from <top (required)> at /my-app/config/environment.rb:5) ```
elia
force-pushed
the
elia/dont-autoload-user-class-handle
branch
from
0dc4498 to
d605e9d
Compare
jarednorman
approved these changes
Nov 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This class is potentially loaded during initialization when used by
factories and that can generate problems with reloaders.
In Rails 6 / zeitwerk that resulted in this warning message:
Checklist: