Remove all usage of FooAbility and BarAbility when testing abilities#3850
Merged
kennyadsl merged 4 commits intosolidusio:masterfrom Nov 27, 2020
Merged
Conversation
BarAbility is deprecated and will be removed in Solidus 3.0. Makes less sense to keep this FooAbility that is also almost unused.
All abilities are reset in a
after(:each) {
Spree::Ability.abilities = Set.new
}
at the beginning of the file.
It's deprecated but the deprecation message was silenced for some reason. This commit allow us to avoid using that class switching to an anonymous class that does the same.
It is deprecated and now unused
kennyadsl
added
changelog:solidus_core
aldesantis
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is preparatory work for #3816. We need to remove
BarAbilitythat is deprecated, but it's actually still used in the codebase.This PR removes its usage and takes advantage of the change to also remove
FooAbilityclass, which is very similar but wasn't under the radar in a previous refactor because it's not defining a top-level class in our documentation.Needs backport on v2.11.
Checklist: