Remove ability to void invalid payments#3858
Merged
kennyadsl merged 2 commits intosolidusio:masterfrom Dec 14, 2020
Merged
Conversation
Update fork
kennyadsl
reviewed
Dec 9, 2020
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
I think it makes sense, thanks! I left a question about the implementation that I think we can DRY a bit, let me know!
Voiding invalid payments will result in an error due to the lack of response_code. Additionally, this transition is not allowed in the payment state machine.
vl3
force-pushed
the
remove_ability_to_void_invalid_payments
branch
from
ff27f7f to
f4637c9
Compare
kennyadsl
added
release:major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
My reasoning behind this is that attempts to void invalid payments will fail because response_code is not set for invalid payments. There are several things that suggests that transitioning from invalid to void should be forbidden (although that the payment could be reattempted, but that's another story).
So everything suggests that invalid state should be final and, other than reattempting the payment , we should block this transition. Attached is an screenshot of how the admin panel will understand transitions.
Before
After
Checklist: