Deprecate unused calculators#3863
Merged
kennyadsl merged 3 commits intosolidusio:masterfrom Dec 16, 2020
Merged
Conversation
because it's no longer used ref solidusio@57248d3
This method is deprecated in favour of Spree::Calculator::PercentOnLineItem ref solidusio@983e5aa
This calculator in present in the codebase but not available anywhere in the admin since it is not added in the array of available calculators in app_configuration.rb.
kennyadsl
approved these changes
Dec 14, 2020
spaghetticode
approved these changes
Dec 15, 2020
Member
spaghetticode
left a comment
spaghetticode
left a comment
There was a problem hiding this comment.
thanks @DanielePalombo 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following models have been deprecated without making any warning messages.
solidus/core/app/models/spree/calculator/free_shipping.rb
Line 6 in 3382105
solidus/core/app/models/spree/calculator/percent_per_item.rb
Line 12 in 3382105
This PR is going to add the related deprecation message.
Checklist: