Remove awesome_nested_set override for Rails 6.1 compatibility#3893
Merged
kennyadsl merged 2 commits intosolidusio:masterfrom Jan 19, 2021
Merged
Remove awesome_nested_set override for Rails 6.1 compatibility#3893kennyadsl merged 2 commits intosolidusio:masterfrom
kennyadsl merged 2 commits intosolidusio:masterfrom
Conversation
We introduced this override when preliminary testing Solidus against Rails 6.1, mainly to be sure we were ready with ActiveStorage once Rails 6.1 come out. This work is done in 521e013 and 73cd0ef. Now that awesome_nested_set 3.3.1 has been released with the Rails 6.1 compatibility we can remove this override.
tvdeyen
approved these changes
Jan 12, 2021
jarednorman
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref #3871
This PR bumps
awesome_nested_setdependency to the first version that includes the compatibility with Rails 6.1 and removes the code that we were using to override it in order to make it compatible.This PR needs to be backported to Solidus 2.11 which will also be compatible with Rails 6.1
cc/ @filippoliverani