[Admin] Automatically check edited return items in RMA form#3904
Merged
kennyadsl merged 1 commit intosolidusio:masterfrom Jan 28, 2021
Merged
Conversation
spaghetticode
force-pushed
the
spaghetticode/autocheck-return-items
branch
from
970742a to
05851c8
Compare
houndci-bot
reviewed
Jan 20, 2021
| this.$el.append(tfoot); | ||
|
|
||
| this.$el.find('input, select').not('.add-item').on('change', function(e) { | ||
| $(this).closest('tr').find('input.add-item').prop('checked', true).change(); |
There was a problem hiding this comment.
Expected line break before .change newline-per-chained-call
aldesantis
approved these changes
Jan 20, 2021
Member
aldesantis
left a comment
aldesantis
left a comment
There was a problem hiding this comment.
@spaghetticode thanks, looking good. The only comment I have is that the PR title/commit message could maybe describe what is being changed a bit better — it isn't 100% clear that this is affecting the RMA flow.
kennyadsl
added
Needs Backport
changelog:solidus_backend
spaghetticode
changed the title
This feature got lost with solidusio#3565. It automatically checks rows where the admin changes something, under the assumption that, if a value is changed, then the user means to include the row into the RMA/return. An integration spec is added to properly track this feature.
spaghetticode
force-pushed
the
spaghetticode/autocheck-return-items
branch
from
05851c8 to
3c5e610
Compare
jarednorman
approved these changes
Jan 21, 2021
Member
|
Merging, the only failing spec is already addressed in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature got lost with #3565. It automatically checks rows where the admin changes something, under the assumption that, if a value is changed, then the user means to include the row into the RMA/return.
An integration spec is added to properly track this feature.
Checklist: