Switch to the correct ActiveStorage variant syntax#4003
Merged
kennyadsl merged 2 commits intosolidusio:masterfrom Apr 14, 2021
Merged
Switch to the correct ActiveStorage variant syntax#4003kennyadsl merged 2 commits intosolidusio:masterfrom
kennyadsl merged 2 commits intosolidusio:masterfrom
Conversation
jarednorman
reviewed
Mar 19, 2021
Member
|
@jarednorman can you please review again? |
kennyadsl
added
Needs Backport
changelog:solidus_core
jarednorman
approved these changes
Apr 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the syntax that we're using to create variants from main
ActiveStorageimages in our attachment decorator.Since Rails 6.0,
MiniMagiksyntax has been depreacted in favor ofImageProcessingwrapper gem.Checklist:
[ ] I have updated Guides and README accordingly to this change (if needed)[ ] I have added tests to cover this change (if needed)[ ] I have attached screenshots to this PR for visual changes (if needed)