Skip to content

Backport #4080 to Solidus 2.11#4090

Merged
kennyadsl merged 1 commit intosolidusio:v2.11from
spaghetticode:spaghetticode/permit-return_reason_id
Jun 1, 2021
Merged

Backport #4080 to Solidus 2.11#4090
kennyadsl merged 1 commit intosolidusio:v2.11from
spaghetticode:spaghetticode/permit-return_reason_id

Conversation

@spaghetticode
Copy link
Copy Markdown
Member

This PR backports #4080 to Solidus 2.11.

When creating a new customer return, the admin interface allows to edit the return reason for return items, but the parameter was rejected by the controller since it was actually not permitted, thus preventing the editing of that field.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

When creating a new customer return, the admin interface allows to
edit the return reason for return items, but the parameter was
rejected by the controller since it was actually not permitted,
thus preventing the editing of that field.
@spaghetticode spaghetticode self-assigned this May 31, 2021
@kennyadsl kennyadsl merged commit 07bdb8d into solidusio:v2.11 Jun 1, 2021
@kennyadsl
Copy link
Copy Markdown
Member

@spaghetticode Do we also need to backport this in 3.0?

@spaghetticode
Copy link
Copy Markdown
Member Author

@kennyadsl It makes sense. I'll soon open a PR for that as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants