v2.11 fix(Address): Set name from firstname and lastname on update#4224
Merged
tvdeyen merged 1 commit intosolidusio:v2.11from Jan 7, 2022
Merged
v2.11 fix(Address): Set name from firstname and lastname on update#4224tvdeyen merged 1 commit intosolidusio:v2.11from
tvdeyen merged 1 commit intosolidusio:v2.11from
Conversation
tvdeyen
changed the title
kennyadsl
reviewed
Dec 16, 2021
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
Left a question to better understand the context where this is a problem. Thanks Thomas!
kennyadsl
reviewed
Dec 28, 2021
Member
kennyadsl
left a comment
kennyadsl
left a comment
There was a problem hiding this comment.
I'm ok with the fix, thanks, Thomas. Just left a couple of questions on the specs.
tvdeyen
force-pushed
the
4094-fix-address-update
branch
from
61891f4 to
f56ab5b
Compare
jarednorman
approved these changes
Jan 3, 2022
spaghetticode
approved these changes
Jan 5, 2022
Member
spaghetticode
left a comment
spaghetticode
left a comment
There was a problem hiding this comment.
Looks good to me, only left a minor cleanup note but not blocking... thanks!
If use_combined_first_and_last_name_in_address is false (default) and firstname and lastname are given in the changeset (ie. from a form) we need to make sure that name is set from it, otherwise data will be inconsistent. Closes solidusio#4094
tvdeyen
force-pushed
the
4094-fix-address-update
branch
from
f56ab5b to
a09c84c
Compare
kennyadsl
approved these changes
Jan 7, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If
use_combined_first_and_last_name_in_addressisfalse(default in v2.11) andfirstnameandlastnameare given in the changeset (ie. from a form) we need to make sure that name is set from it, otherwise data will be inconsistent.Closes #4094
Checklist: