[v4.1] Deprecate Spree::Deprecation in favor of Spree.deprecator
#6103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/rails/rails/blob/814f8ee068814e3d4832a607f49f155e02a609c0/activesupport/lib/active_support/deprecation.rb#L6-L34 Add Spree.deprecator to the list of app deprecators as suggested by Rails, this will allow applying the global deprecation configurations to our engine deprecations as well. Eg: config.active_support.deprecation = :raise This will set the deprecation behavior to raise an exception on any of the deprecators under `Rails.application.deprecators`. (cherry picked from commit 44d20af)
(cherry picked from commit e822f3f) # Conflicts: # backend/app/controllers/spree/admin/stock_items_controller.rb # backend/app/helpers/spree/admin/navigation_helper.rb # backend/app/views/spree/admin/shared/_product_sub_menu.html.erb # backend/app/views/spree/admin/shared/_promotion_sub_menu.html.erb # backend/app/views/spree/admin/shared/_settings_sub_menu.html.erb # backend/lib/spree/backend_configuration/deprecated_tab_constants.rb # backend/lib/spree/backend_configuration/menu_item.rb # backend/spec/helpers/admin/navigation_helper_spec.rb # backend/spec/lib/spree/backend_configuration/menu_item_spec.rb # backend/spec/lib/spree/backend_configuration_spec.rb # core/app/models/spree/adjustment.rb # core/lib/spree/deprecation.rb
Use autoload to print a deprecation only if the constant is loaded. (cherry picked from commit 848bf9f) # Conflicts: # core/lib/spree/deprecation.rb
(cherry picked from commit a7dd17b)
4 tasks
github-actions
bot
added
changelog:solidus_core
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.1 #6103 +/- ##
==========================================
- Coverage 88.74% 88.70% -0.05%
==========================================
Files 563 564 +1
Lines 13885 13896 +11
==========================================
+ Hits 12322 12326 +4
- Misses 1563 1570 +7 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Feb 10, 2025
jarednorman
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.1:Questions ?
Please refer to the Backport tool documentation