Skip to content

[v4.5] Fix line item option condition params#6395

Merged
mamhoff merged 4 commits intosolidusio:v4.5from
mamhoff:backport/v4.5/pr-6233
Dec 11, 2025
Merged

[v4.5] Fix line item option condition params#6395
mamhoff merged 4 commits intosolidusio:v4.5from
mamhoff:backport/v4.5/pr-6233

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Dec 5, 2025

Backport

This will backport the following commits from main to v4.5:

Questions ?

Please refer to the Backport tool documentation

@mamhoff mamhoff requested a review from a team as a code owner December 5, 2025 14:14
@mamhoff mamhoff added backport-v4.5 Backport this pull-request to v4.5 backport-v4.6 Backport this pull-request to v4.6 changelog:solidus_promotions Changes to the solidus_promotions gem labels Dec 5, 2025
manleyac and others added 4 commits December 10, 2025 17:06
This updates the product picker for the line_item_option_value form
to not allow selecting multiple products per entry.

(cherry picked from commit 36b8821)
This fixes an issue where the option-value-picker was not
receiving the id for the selected product. Therefore the correct
option values where not available and the params where malformed.

(cherry picked from commit 8947ff5)
When creating an option value condition, we only want to have option
values that fit the product in question. This commit makes it such that
the option value picker re-initializes when the selected product
changes.

(cherry picked from commit b45afe7)
(cherry picked from commit b0eda8b)

# Conflicts:
#	promotions/config/locales/en.yml
@mamhoff mamhoff force-pushed the backport/v4.5/pr-6233 branch from b6e876c to c853e41 Compare December 10, 2025 16:06
@mamhoff mamhoff merged commit 2b038b3 into solidusio:v4.5 Dec 11, 2025
5 checks passed
@solidus-bot
Copy link
Copy Markdown

solidus-bot Bot commented Dec 11, 2025

💔 All backports failed

Status Branch Result
v4.6 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 6395

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.5 Backport this pull-request to v4.5 backport-v4.6 Backport this pull-request to v4.6 changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants