Skip to content

Fix order walkthrough for iso uniqueness#6432

Open
AlistairNorman wants to merge 1 commit intosolidusio:mainfrom
SuperGoodSoft:country-iso-uniqueness
Open

Fix order walkthrough for iso uniqueness#6432
AlistairNorman wants to merge 1 commit intosolidusio:mainfrom
SuperGoodSoft:country-iso-uniqueness

Conversation

@AlistairNorman
Copy link
Copy Markdown
Contributor

@AlistairNorman AlistairNorman commented Apr 8, 2026

Summary

Alternatively I also considered adding initialize_with { Spree::Country.find_or_initialize_by(iso:) } to the factory which seems like a broader solution to making sure iso uniqueness doesn't break tests but I find initialize_with results in some very unintuitive behaviour so I opted to avoid it.

If anyone wants to see the test failures, they can see this run. Not all of the failures are from the iso issue but a bunch of them are.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

ISO is now a unique field on countries which means that creating two
countries errors. Creating the country here broke tests in some
extensions including solidus_starter_frontend.
@AlistairNorman AlistairNorman requested a review from a team as a code owner April 8, 2026 03:15
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (0994f63) to head (75c5aeb).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ore/lib/spree/testing_support/order_walkthrough.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6432   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20798    20792    -6     
=======================================
- Hits        18649    18644    -5     
+ Misses       2149     2148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AlistairNorman added a commit to SuperGoodSoft/solidus_starter_frontend that referenced this pull request Apr 8, 2026
This can be dropped once we merge solidusio/solidus#6432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants